Improve DEX place-order CLI #1050
Conversation
dzmitryhil
requested review from
masihyeganeh,
miladz68 and
ysv
and removed request for
a team
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1050 +/- ##
=======================================
Coverage 62.44% 62.44%
=======================================
Files 160 160
Lines 18587 18587
=======================================
+ Hits 11606 11607 +1
+ Misses 5863 5861 -2
- Partials 1118 1119 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @miladz68, and @ysv)
x/dex/client/cli/tx.go line 71 at r1 (raw file):
Example: $ %s tx %s cored tx dex place-order ORDER_TYPE_LIMIT "my-order-id1" denom1 denom2 1000 SIDE_SELL --price 12e-1 --time-in-force=TIME_IN_FORCE_GTC --from [sender]
The %s tx %s will produce cored tx dex. You don't need to add it again
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh, @miladz68, and @ysv)
x/dex/client/cli/tx.go line 71 at r1 (raw file):
Previously, masihyeganeh (Masih Yeganeh) wrote…
The
%s tx %swill producecored tx dex. You don't need to add it again
Agree, updated.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @miladz68 and @ysv)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status:
Description
place-orderCLI.Reviewers checklist:
Authors checklist
This change is